Skip to content

Gcp/service/gke backup#279

Merged
Tikster123 merged 12 commits intodevfrom
gcp/service/gke_backup
Feb 5, 2026
Merged

Gcp/service/gke backup#279
Tikster123 merged 12 commits intodevfrom
gcp/service/gke_backup

Conversation

@Tikster123
Copy link
Contributor

@Tikster123 Tikster123 commented Jan 25, 2026

No description provided.

Tikster123 and others added 7 commits December 16, 2025 21:07
@Tikster123
feat: Migrate GKE Backup policies to new modular helper system
31904e6 
- Migrated 52 policy files from monolithic to modular helpers
- Added new modular helper system in policies/_helpers/
- Created comprehensive test inputs for all policies
- Fixed OPA evaluation errors with duplicate function definitions
- Implemented all 6 resource types with proper validations
@Tikster123
Merge main branch - kept main version of test/template files
6224c81
@Tikster123
Resolve merge conflicts - use main branch versions of test/template f…
e7974b6 
…iles
@Tikster123
Remove templates/gcp/policy.rego - file not in main branch
7d3754d
@Tikster123
Merge branch 'dev' into gcp/service/gke_backup
debe156
@Tikster123
Complete GKE Backup documentation
d562534
@Tikster123
Update Backup_for_GKE policies and documentation
26b6461
Shani1116
Shani1116 requested changes Jan 28, 2026
View reviewed changes
@Shani1116
Copy link
Contributor

Shani1116 commented Jan 28, 2026

Screenshot 2026-01-28 132809 There are no matching policies for the above files. Please check and add any missing policies.

@Shani1116
Copy link
Contributor

Shani1116 commented Jan 31, 2026

@Tikster123 Reviewed your responses to the PR comments. Please note that custom functions are not permitted in PDE policies as they do not follow the accepted PDE format.
Please remove any arbitrary checks and resubmit the policies using the correct format.

@Tikster123
Copy link
Contributor Author

Tikster123 commented Feb 1, 2026

@Tikster123 Reviewed your responses to the PR comments. Please note that custom functions are not permitted in PDE policies as they do not follow the accepted PDE format. Please remove any arbitrary checks and resubmit the policies using the correct format.

Hi Shanika, i have replaced the auto_test.py to its original format and also made sure the custom roles are not present and that my policies follow the correct format thank you!

@Shani1116 Shani1116 self-assigned this Feb 1, 2026
Shani1116
Shani1116 requested changes Feb 2, 2026
View reviewed changes
Copy link
Contributor

@Shani1116 Shani1116 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the new PR comments, resolve and resubmit. Also, please make sure that you merge latest update from the dev branch to resolve any merge conflicts.

@Tikster123
Copy link
Contributor Author

Tikster123 commented Feb 2, 2026

Please check the new PR comments, resolve and resubmit. Also, please make sure that you merge latest update from the dev branch to resolve any merge conflicts.

made the necessary changes by deleting the files and also merged the latest updates from the dev branch, Thank you so much for your time Shanika!

Shani1116
Shani1116 approved these changes Feb 4, 2026
View reviewed changes
Copy link
Contributor

@Shani1116 Shani1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved all PR comments. Approved!

@Tikster123 Tikster123 merged commit 3407dc6 into dev Feb 5, 2026
1 check failed
@Tikster123 Tikster123 deleted the gcp/service/gke_backup branch February 5, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shani1116 Shani1116 Shani1116 approved these changes

Assignees

@Shani1116 Shani1116

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tikster123 @Shani1116